Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: one two button dialog #81

Merged
merged 28 commits into from
Jan 30, 2024
Merged

feat: one two button dialog #81

merged 28 commits into from
Jan 30, 2024

Conversation

markuczy
Copy link
Contributor

Additions:

  • ButtonDialogComponent which displays 1/2 configurable buttons with possibility to provide fully configurable inner content
  • PortalDialogService.openDialog() method that simplifies dialog creation and uses ButtonDialogComponent as a wrapper for message/component to display inside the dialog
  • Tests for ButtonDialogComponent
  • Tests for openDialog() method with various scenarios with different components

markuczy added 17 commits December 4, 2023 13:12
@markuczy
button-dialog compontent implemented with tests
84ecba1
@markuczy
lint
ba0f3e0
@markuczy
review fix
98d36c6
@markuczy
build fix
7867f4f
@markuczy
refactored button-dialog component
550b739
@markuczy
added possibility to project host inline
1da69c5
@markuczy
adjusted template and buttons interfaces
3c1c9fa
@markuczy
naming fixes
4af130d
@markuczy
feat: PortalDialogService base usage
e0ce47e
@markuczy
feat: initialization of dialog implemented and tested
d14fb0f
@markuczy
feat: portal-dialog-service works with DialogResult interface
85919bb
@markuczy
feat: PoratlDialogService works with DialogButtonClicked interface
2868173
@markuczy
feat: PortalDialogService works with ButtonDisabled interfaces
e863787
@markuczy
feat: PortalDialogService open tested with complex component
00ef37b
@markuczy
fix: renamed function and changed test name
4913a28
@markuczy
Merge branch 'main' into feat/P002271-5729-one-two-button-dialog
8385357
@markuczy
fix: cleanup naming and imports
854c4ec
SchettlerKoehler
SchettlerKoehler requested changes Jan 25, 2024
View reviewed changes
.../portal-integration-angular/src/lib/core/components/button-dialog/button-dialog.component.ts Outdated Show resolved Hide resolved
.../portal-integration-angular/src/lib/core/components/button-dialog/button-dialog.component.ts Outdated Show resolved Hide resolved
.../portal-integration-angular/src/lib/core/components/button-dialog/button-dialog.component.ts Outdated Show resolved Hide resolved
.../portal-integration-angular/src/lib/core/components/button-dialog/button-dialog.component.ts Outdated Show resolved Hide resolved
.../portal-integration-angular/src/lib/core/components/button-dialog/button-dialog.component.ts Outdated Show resolved Hide resolved
libs/portal-integration-angular/src/lib/services/portal-dialog.service.ts Outdated Show resolved Hide resolved
libs/portal-integration-angular/src/lib/services/portal-dialog.service.ts Outdated Show resolved Hide resolved
libs/portal-integration-angular/testing/button-dialog.harness.ts Outdated Show resolved Hide resolved
libs/portal-integration-angular/testing/button-dialog.harness.ts Outdated Show resolved Hide resolved
libs/portal-integration-angular/testing/primeng/p-button-directive.harness.ts Show resolved Hide resolved
@SchettlerKoehler SchettlerKoehler changed the title Feat/p002271-5729 one two button dialog feat: one two button dialog Jan 25, 2024
SchettlerKoehler
SchettlerKoehler requested changes Jan 30, 2024
View reviewed changes
.../portal-integration-angular/src/lib/core/components/button-dialog/button-dialog.component.ts Outdated Show resolved Hide resolved
libs/portal-integration-angular/src/lib/model/button-dialog.ts Outdated Show resolved Hide resolved
libs/portal-integration-angular/src/lib/services/portal-dialog.service.ts Show resolved Hide resolved
libs/portal-integration-angular/src/lib/services/portal-dialog.service.ts Outdated Show resolved Hide resolved
libs/portal-integration-angular/src/lib/services/portal-dialog.service.ts Outdated Show resolved Hide resolved
libs/portal-integration-angular/src/lib/services/portal-dialog.service.ts Outdated Show resolved Hide resolved
libs/portal-integration-angular/src/lib/services/portal-dialog.service.ts Show resolved Hide resolved
libs/portal-integration-angular/src/lib/services/portal-dialog.service.ts Show resolved Hide resolved
libs/portal-integration-angular/src/lib/services/portal-dialog.service.ts Outdated Show resolved Hide resolved
libs/portal-integration-angular/src/lib/services/portal-dialog.service.ts Show resolved Hide resolved
@SchettlerKoehler SchettlerKoehler merged commit aeef8b0 into onecx:main Jan 30, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Feb 1, 2024
@semantic-release-bot
chore(release): -v4.2.0 [skip ci]
b4ca427 
## [4.2.0](v4.1.2...v4.2.0) (2024-02-01)

### Features

* one two button dialog ([#81](#81)) ([aeef8b0](aeef8b0))
* P002271-6620-export-function ([#92](#92)) ([3c2c766](3c2c766))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchettlerKoehler SchettlerKoehler SchettlerKoehler requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markuczy @SchettlerKoehler